feat(dramatiq): Support span streaming#6273
Merged
Merged
Conversation
Contributor
Codecov Results 📊✅ 79 passed | Total: 79 | Pass Rate: 100% | Execution Time: 1.06s All tests are passing successfully. ❌ Patch coverage is 11.76%. Project has 16047 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
sl0thentr0py
force-pushed
the
neel/span-first-dramatiq
branch
2 times, most recently
from
326b013 to
4b5aa52
Compare
sentrivana
reviewed
May 18, 2026
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Couple things, please see comments
| if not is_event_capture_required: | ||
| # normal transaction finish | ||
| transaction.__exit__(None, None, None) | ||
| span_ctx.__exit__(None, None, None) |
Contributor
There was a problem hiding this comment.
The canonical way to do this in span first would just be span.end(), but I get that this way it's compatible with both legacy and span streaming mode
Add a span-streaming branch in SentryMiddleware.before_process_message and after_process_message alongside the legacy transaction-based path, gated on has_span_streaming_enabled. The streaming branch uses sentry_sdk.traces.continue_trace + start_span and stashes the span context manager on the message so the after-hook can exit it without relying on scope.transaction (which doesn't exist in streaming mode). Parametrize the tracing tests over span_streaming True/False so both modes are covered. Refs GH-5386 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
sl0thentr0py
force-pushed
the
neel/span-first-dramatiq
branch
from
5e0f289 to
a118d2f
Compare
sentrivana
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues